chore: when a cluster event occurs, create config map instead of secret#280
Merged
Conversation
if labelValue, exists := cmObject.Labels["type"]; !exists || labelValue != informerBean.ClusterModifyEventSecretType {
return
}
# Conflicts: # common-lib/utils/k8s/K8sUtil.go # kubelink/go.mod # kubelink/go.sum # kubelink/vendor/github.com/devtron-labs/common-lib/utils/k8s/K8sUtil.go # kubelink/vendor/modules.txt # kubewatch/go.mod # kubewatch/go.sum # kubewatch/vendor/github.com/devtron-labs/common-lib/utils/k8s/K8sUtil.go # kubewatch/vendor/modules.txt
prakash100198
requested review from
nishant-d,
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
Ash-exp
requested changes
May 27, 2025
nishant-d
suggested changes
May 27, 2025
Ash-exp
previously approved these changes
May 27, 2025
# Conflicts: # kubelink/go.mod # kubelink/go.sum # kubelink/vendor/modules.txt # kubewatch/go.mod # kubewatch/go.sum # kubewatch/vendor/modules.txt
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
Ash-exp
approved these changes
Jun 9, 2025
prakash100198
changed the title
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
1 similar comment
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
nishant-d
approved these changes
Jun 10, 2025
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
prakash100198
changed the title
github-actions
Bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains changes in following:-
Fixes #https://github.com/devtron-labs/sprint-tasks/issues/2177